Can't use both warning and catch in a yamlRestTest

[joegallo]

I discovered this while I was working on #75951. For one of the tests I wanted to write there, the expected outcome is that I'd get both a json body error from ES, and also a warning header. It turns out, though, if you use a catch, then any associated warning elements from the test are ignored.

It's easy enough to see why that is in the code. checkWarningHeaders is called after a successful response, but error responses go into the catch block for catch processing, and there's no associated call to checkWarningHeaders there.

diff --git a/test/framework/src/main/java/org/elasticsearch/test/rest/yaml/section/DoSection.java b/test/framework/src/main/java/org/elasticsearch/test/rest/yaml/section/DoSection.java
index 0223ef27b6c..0fe690be379 100644
--- a/test/framework/src/main/java/org/elasticsearch/test/rest/yaml/section/DoSection.java
+++ b/test/framework/src/main/java/org/elasticsearch/test/rest/yaml/section/DoSection.java
@@ -367,6 +367,11 @@ public class DoSection implements ExecutableSection {
             } else {
                 throw new UnsupportedOperationException("catch value [" + catchParam + "] not supported");
             }
+
+            final String testPath = executionContext.getClientYamlTestCandidate() != null
+                ? executionContext.getClientYamlTestCandidate().getTestPath()
+                : null;
+            checkWarningHeaders(restTestResponse.getWarningHeaders(), testPath);
         }
     }

^ appears to do the trick, but then there are failures in the yamlRestCompatTests -- I suppose that means that some of our tests incidentally happen to rely on the current behavior.

[elasticmachine]

Pinging @elastic/es-core-infra (Team:Core/Infra)

[nik9000]

Neat! I'm not surprised we ignored warnings when we didn't have to mark them.