Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish "repository doesn't exist" from "repository plugin not installed" #81758

Closed
DaveCTurner opened this issue Dec 15, 2021 · 1 comment · Fixed by #82457
Closed

Distinguish "repository doesn't exist" from "repository plugin not installed" #81758

DaveCTurner opened this issue Dec 15, 2021 · 1 comment · Fixed by #82457
Assignees
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team

Comments

@DaveCTurner
Copy link
Contributor

Elasticsearch version (bin/elasticsearch --version): 7.16.1 (and many others)

Plugins installed: []

JVM version (java -version): Any

OS version (uname -a if on a Unix-like system): Any

Description of the problem including expected versus actual behavior:

If you define a repository using a plugin and then remove the plugin then the RepositoryMetadata lives on but we do not create a corresponding Repository instance. This means that operations on the repository (creating snapshots etc) will fail with a RepositoryMissingException which is very confusing because GET _snapshot will show that the repository is not missing at all.

I believe in this case we should create a placeholder Repository instance so that operations on the repository fail with a more helpful message.

@DaveCTurner DaveCTurner added >bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Dec 15, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Dec 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants