Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still OOM in the processing of search reduce phase #85166

Open
boicehuang opened this issue Mar 21, 2022 · 2 comments
Open

Still OOM in the processing of search reduce phase #85166

boicehuang opened this issue Mar 21, 2022 · 2 comments

Comments

@boicehuang
Copy link
Contributor

boicehuang commented Mar 21, 2022

Bucket aggregation will consume a lot of memory on the coordinate node if it has a huge number of resulting buckets. search.max_buckets setting could limit maximum number of buckets allowed in a single response. Sometimes user may increase this setting to get more buckets, but it also increases the risk of OOM. It's hard to evaluate a suitable value for max_buckets.

PR #46751 introduces search.check_buckets_step_size setting and does a parent circuit breaker checking whenever allocating a certain number of new buckets. But it won't work after the change of PR #57042. Originally, consumeBucketsAndMaybeBreak was checked every time a bucket was generated. But now it would only be checked after reduce phase produces the result. It is easier to cause OOM during the reduce phase.

image

@nik9000 nik9000 added the :Analytics/Aggregations Aggregations label Mar 21, 2022
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 21, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@nik9000 nik9000 added >regression and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Mar 21, 2022
@boicehuang
Copy link
Contributor Author

@imotov can you please have a look? Any help will be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants