Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins may leave junk in the cluster state, requiring lenient parsing and possibly preventing their removal #88984

Open
DaveCTurner opened this issue Aug 1, 2022 · 1 comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team

Comments

@DaveCTurner
Copy link
Contributor

As noted at #21471 (comment), today we assume that anything in the cluster Metadata that we don't recognise must belong to a plugin that has since been uninstalled, and just leniently ignore it. We should be stricter about this, but if we were simply to fail to start in this state then it would not be possible to remove a plugin that records anything in the cluster Metadata unless the plugin implemented a way to remove its metadata whilst still installed. Additionally there's not really a stable interface for plugins to manipulate this state today.

If we do intend to permit plugins to record information in Metadata then I think we should not use a bare Custom manipulated with the internal APIs, and should instead use a plugin-specific structure that better supports uninstallation.

@DaveCTurner DaveCTurner added :Core/Infra/Plugins Plugin API and infrastructure team-discuss labels Aug 1, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

No branches or pull requests

4 participants