Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve module/plugin loading logging messages #93881

Closed
rjernst opened this issue Feb 17, 2023 · 2 comments · Fixed by #93952
Closed

Improve module/plugin loading logging messages #93881

rjernst opened this issue Feb 17, 2023 · 2 comments · Fixed by #93952
Labels
:Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team

Comments

@rjernst
Copy link
Member

rjernst commented Feb 17, 2023

When Elasticsearch starts up, plugins are loaded based on their inter-dependencies. The specific order used is sometimes useful to see. Currently though the actual order cannot be seen. Instead the modules and plugins are logged in name sorted order after all loading has occurred.

We should be more clear about what order the plugins are actually loaded in, though we do need to be careful as to not add too much noise. I suggest moving the "loaded xxx module" message to the actual loading method in PluginsService (it will require passing through whether the code being loaded is a module or plugin).

@rjernst rjernst added the :Core/Infra/Plugins Plugin API and infrastructure label Feb 17, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 17, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@howardhuanghua
Copy link
Contributor

howardhuanghua commented Feb 20, 2023

Hi @rjernst , I am going to submit a PR to fix this issue. I would add isModule boolean for PluginService to distinguish module or plugin. And print all the dependency sorted pluginsLoaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure Team:Core/Infra Meta label for core/infra team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants