Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILM allows a policy name that generates invalid snapshot name #95593

Closed
dakrone opened this issue Apr 26, 2023 · 1 comment · Fixed by #95767
Closed

ILM allows a policy name that generates invalid snapshot name #95593

dakrone opened this issue Apr 26, 2023 · 1 comment · Fixed by #95767
Assignees
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team

Comments

@dakrone
Copy link
Member

dakrone commented Apr 26, 2023

We allow characters in the ID of an ILM policy that will result in an invalid snapshot name.

For example, an ILM policy with the name mypolicy-* can be created, however, the generation of the snapshot name in this line:

String snapshotNamePrefix = ("<{now/d}-" + index.getName() + "-" + policyName + ">").toLowerCase(Locale.ROOT);

Results in the mypolicy-* being part of the snapshot name, which the snapshot service then disallows. We should strip these invalid characters from the snapshot name.

@dakrone dakrone added >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Apr 26, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Apr 26, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants