Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index version compatibility setting does not use its validator #95873

Closed
thecoop opened this issue May 5, 2023 · 2 comments · Fixed by #95874
Closed

Index version compatibility setting does not use its validator #95873

thecoop opened this issue May 5, 2023 · 2 comments · Fixed by #95874
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs :Search/Search Search-related issues that do not fall into other categories Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team

Comments

@thecoop
Copy link
Member

thecoop commented May 5, 2023 •
edited

Setting.versionSetting (only used by index compatibility setting) does not use the Validator passed in - its just discarded. Looks like it's been like this since it was introduced by #83264 in 8.2.0.

Enabling this causes some tests to fail. Enabling this may cause problems for indexes that have a wonky setting already applied.
@thecoop thecoop added >bug :Core/Infra/Settings Settings infrastructure and APIs :Search/Search Search-related issues that do not fall into other categories labels May 5, 2023
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team labels May 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@thecoop thecoop mentioned this issue May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs :Search/Search Search-related issues that do not fall into other categories Team:Core/Infra Meta label for core/infra team Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable validation for versionSettings thecoop/elasticsearch
2 participants
@thecoop @elasticsearchmachine