docker-entrypoint.sh uses a mix of absolute and relative/implied paths

[DaveCTurner]

We invoke elasticsearch via its absolute path here:

elasticsearch/distribution/docker/src/docker/bin/docker-entrypoint.sh

Line 84 in d5b1356

exec /usr/share/elasticsearch/bin/elasticsearch "$@" $POSITIONAL_PARAMETERS <<<"$KEYSTORE_PASSWORD"

However we also invoke elasticsearch-keystore in several places, and none of them specify its path so we are relying on picking up the right binary from $PATH. For instance:

elasticsearch/distribution/docker/src/docker/bin/docker-entrypoint.sh

Line 43 in d5b1356

[[ -f /usr/share/elasticsearch/config/elasticsearch.keystore ]] || (elasticsearch-keystore create)

We also check for the existence of bin/elasticsearch-users relative to the current directory:

elasticsearch/distribution/docker/src/docker/bin/docker-entrypoint.sh

Line 35 in d5b1356

if [[ -f bin/elasticsearch-users ]]; then

Should these all be absolute paths to avoid any ambiguity if running in a slightly weird environment? I ask because a user on the forums needed to make some adjustments to how we start up within their Docker environment, and these non-absolute paths got in their way a bit.

[elasticsearchmachine]

Pinging @elastic/es-delivery (Team:Delivery)

[mark-vieira]

Should these all be absolute paths to avoid any ambiguity if running in a slightly weird environment?

I think there are some implicit expectations here that the working directory of many scripts is $ES_HOME. See here.

That said, that's after the docker-entrypoint.sh script is run so we could probably make it agnostic to working directory.

Do you have any details on this specific use-case?

[mark-vieira]

@DaveCTurner I'm not sure we're planning on making any changes here. I went back and looked at the original forums post and I think the best solution for that use case would be to use a customized docker image rather than trying to override the image entrypoint. I don't think there's a compelling reason or use-case for using absolute paths in this script when we explicitly add the bin directory to PATH. Both for convenience, and so folks can do things like docker run elasticsearch:latest elasticsearch-keystore w/o having to specify an absolute path.