New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change QueryTemplateParser to use script naming convention #9995
Comments
Or Also, we can leave |
@clintongormley yep, good point. It should be noted that ScriptParameterParser can still be used for this since it accepts arbitrary prefixes as well as the default |
I think we should come up with a |
+1 on the |
Closed in favour of #11164 |
At the moment the QueryTemplateParser uses
query
,file
andid
for inline, file and indexed scripts respectively. Since the naming convention for scripts is nowscript
,script_file
andscript_id
(enforced by using the ScriptParameterParser) we should change this API to follow the same convention. We may want to keepquery
as an option for inline scripts as it makes sense in this context but we should supportscript
too.file
andid
should be replaced withscript_file
andscript_id
.Original comment in: https://github.com/elasticsearch/elasticsearch/pull/9992/files#r25855691
The text was updated successfully, but these errors were encountered: