-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect query params #10
Comments
@silamon can you report the versions of |
We're using 7.16 for app search and 7.16 for enterprise search php. When we want to fetch the second or third page, we always receive the first page as if the parameter we've sent using ListEngines -> SetCurrentPage is ignored. Relevant code: EDIT: "current_page" isn't mentioned anywhere, not in the query params documentation and not in the body documentation. |
Thank you for looking into this! Very much appreciated! 👍 |
We're having problems fetching any other page than the default page for the list engine operation with the last published version.
Looking at the code, it looks like the query_params are incorrect on some release branches:
https://github.com/elastic/enterprise-search-php/blob/7.15/src/AppSearch/Request/ListEngines.php
While the code on the master branch uses the correct query_params:
https://github.com/elastic/enterprise-search-php/blob/master/src/AppSearch/Request/ListEngines.php
And one of the older releases uses the correct query_params as well:
https://github.com/elastic/enterprise-search-php/blob/7.14/src/AppSearch/Request/ListEngines.php
Relevant documentation: https://www.elastic.co/guide/en/app-search/7.15/engines.html#engines-query-list
The text was updated successfully, but these errors were encountered: