Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect property name #35

Closed
bsatoris opened this issue Jan 27, 2023 · 3 comments
Closed

Incorrect property name #35

bsatoris opened this issue Jan 27, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bsatoris
Copy link

The SearchRequestParams class in AppSearch has a property called boost which I think should be called boosts.

If you attempt to build a query using boost you will get an invalid key error. The API wants boosts.

$params->boosts = new Schema\SearchBoosts();
....
//works

compare to

$params->boost = new Schema\SearchBoosts();
...
//does not work
@ezimuel
Copy link
Contributor

ezimuel commented Feb 7, 2023

@bsatoris thanks for reporting this. There was a typo in the specification. I'll fix it soon.

@ezimuel ezimuel self-assigned this Feb 7, 2023
@ezimuel ezimuel added the bug Something isn't working label Feb 7, 2023
@ezimuel ezimuel added this to the 8.7.0 milestone Feb 21, 2023
@ezimuel
Copy link
Contributor

ezimuel commented Apr 4, 2023

Fixed in v8.7.0

@ezimuel ezimuel closed this as completed Apr 4, 2023
@groeney
Copy link

groeney commented Oct 4, 2023

Hi @ezimuel could you please have someone look at this fix for the same bug in the python client? It is a two character change, hopefully it is a fast approval. It is currently blocking our improving of the elasticsearch deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants