Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] A way to maintain pageIndex after the data updates #1909

Closed
igoristic opened this issue May 2, 2019 · 3 comments
Closed

Comments

@igoristic
Copy link

igoristic commented May 2, 2019

Our monitoring tables update data every 10s, meaning the rows/data are still the same but some stats/column-values like: memory, cpu, etc changes. The problem is when we go to any other page than 0 and update states the table always reverts to page 0, guessing because of this line here: https://github.com/elastic/eui/pull/1798/files#diff-10dd11a4410be7cac57994d3b55fc179R162

The only way I can fix elastic/kibana#32663 is by un-mounting and remounting the component every 10s, which is not very performant and can flicker on some browsers.

Something to keep in mind if/when implementing: getDerivedStateFromProps is also triggered with table search, so we do still want to keep the current/default behavior of reverting to page 0 when searching

Relates to elastic/kibana#32663

@walterra
Copy link
Contributor

walterra commented Apr 1, 2020

We hit this issue on the Kibana Management page for the transforms list too:

Kapture 2020-04-01 at 15 18 08

In the GIF you can see that the list resets to page 1 (index 0) when hitting the refresh button.

@cchaos cchaos changed the title A way to maintain pageIndex after the EuiInMemoryTable data updates [EuiInMemoryTable] A way to maintain pageIndex after the data updates Sep 19, 2020
@cchaos cchaos added this to Needs triage/design in Tables via automation Sep 19, 2020
@cchaos cchaos moved this from Needs triage/design to EuiInMemoryTable in Tables Sep 19, 2020
@cchaos cchaos removed the tables label Sep 19, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Tables automation moved this from EuiInMemoryTable to Closed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Tables
  
Closed
Development

No branches or pull requests

3 participants