-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiFlyout] Allow resizing #287
Comments
Good idea. This is gonna be more javascripty so it's out of my wheelhouse, so if you or one of the UI engineers has time for it feel free to set up a PR. |
Blocked by #1298 |
@cchaos I'm not sure how the Here's a quick demo of the of the |
While it may/may not be a direct usage of EuiResizableContainer, having done that one first can inform how we'd handle similar functionality for EuiFlyout and possible reuse services and/or components like the resizing handle. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
We need to keep this one going. |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context. |
Going to re-open this as #7290 is ongoing and seems to lean towards "yes" |
@cee-chen I'm going to adjust the priority to "high" and the effort to "medium" (it was previously large). Do you agree? |
Sounds good to me! |
The EUI Team has decided to implement this. I am going to rewrite the description to match our discussions. |
[Edit by @JasonStoltz]
Is your feature request related to a problem? Please describe.
Flyouts can currently be sized programmatically via a
size
prop.This is useful because sizing needs can vary between use cases depending on the page and flyout content.
However, for some use cases, this can actually be limiting, as we can't always predict how much space a user will actually need in their workflow -- the size of dynamic content could differ between users as well as screen size and resolution. Their needs can even during their workflow as their focus shifts back and forth between the primary page content and the flyout content (in the case of a push-based flyout). Some examples include:
Describe the solution you'd like
The ability for flyouts to be resizable should give users the ability to make adjustments that solve this issue.
The implementation could be accomplished by exposing a
resizable
prop for flyouts. If theresizable
prop is set totrue
, then a flyout would be user-resizable.This could be accomplished by adding an
EUIResizableButton
to the flyout. Here is a POC that illustrates this: https://codesandbox.io/s/thirsty-noyce-4gxycf?file=/demo.tsxThis prop could be applied to any flyout (not just "push-based"). The default would be
false
. Would make the defaultfalse
because there are a number things we want folks to consider before making their flyouts resizable. They are as follows:These considerations should be clearly documented as guidance alongside the new prop in the EUI documentation.
Describe alternatives you've considered
An alternative to the resizable flyouts would be using an
EUIResizablePanel
. An example of this is illustrated in this POC. However, requires quite a bit more code to implement.Another alternative would also be to just implement the EUIResizableButton on top of the existing flyout rather than integrating it as a feature of the flyout, as show in this POC. However, as this could/would be used in a number of places, I believe that it would be cleaner and more consistent to add this as a feature of EUI.
Desired timeline
"Sooner rather than later". Both AI Assistant and Discover have an immediate need for this. Do note though, that Discover has a workaround available to them in the meantime. My recommendation is by 8.13.
Additional context
#7290
via elastic/kibana#15901
[Original description by @timroes and @chandlerprall]
It would be nice, to have a
resizeable={true}
property onEuiFlyout
, that will allow the user to resize the flyout by dragging its border.Tasks
The text was updated successfully, but these errors were encountered: