Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace makeId with htmlIdGenerator #3112

Closed
thompsongl opened this issue Mar 17, 2020 · 0 comments · Fixed by #3129
Closed

Replace makeId with htmlIdGenerator #3112

thompsongl opened this issue Mar 17, 2020 · 0 comments · Fixed by #3129
Labels
chore

Comments

@thompsongl
Copy link
Contributor

thompsongl commented Mar 17, 2020 •
edited
Loading

EUI has two utility methods for creating unique identifiers for associating inputs and labels.

makeId:

  • Zero-dependency
  • No affixing/customization
  • Exported from and used exclusively in ./form/
  • No documentation

htmlIdGenerator

  • Uses uuid v1
  • Allows for prefixing and suffixing
  • Exported as part of the public API
  • Documentation in the works

We should change all usage to htmlIdGenerator and deprecate makeId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shifting makeId to htmlIdGenerator NightWing1998/eui
1 participant
@thompsongl