Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] UX Cleanups #4458

Closed
Tracked by #85965
chandlerprall opened this issue Jan 28, 2021 · 1 comment
Closed
Tracked by #85965

[EuiDataGrid] UX Cleanups #4458

chandlerprall opened this issue Jan 28, 2021 · 1 comment

Comments

@chandlerprall
Copy link
Contributor

chandlerprall commented Jan 28, 2021

Originally from #4170 (review)

1. The density adjustments no longer seem to be changing the overall height of the cells. Resolved in #5372
There seems to be some calculations going that always come out to make the cells 34px high.
image

2. In full screen mode, the initial calculation doesn't take the scrollbar into account Resolved
Screen Shot 2021-01-21 at 15 07 33 PM

3. Visually I think we need more borders especially around the scrollbars Resolved in #5563
image

4. It would be great if while scrolling with virtualization which shows a white background while the cells load, we could have either add in some light gray like $euiPageBackgroundColor, or even some sort of pattern indication "loading". Resolved by #5562

5. It looks like we also need a smarter pagination display on skinny screens/containers. Resolved by #5561
Screen Shot 2021-01-21 at 15 42 10 PM

6. In full screen, the bottom row is still getting cutoff by the fixed pagination and it's hiding the horizontal scrollbar. Different densities are cutoff by different amounts. Resolved by #5557
Screen Shot 2021-01-21 at 15 49 17 PM

@cee-chen
Copy link
Member

Closing this out, all individual items should have been resolved!

Tables automation moved this from EuiDataGrid to Closed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Tables
  
Closed
Development

No branches or pull requests

3 participants