[EUI+] Implement sidebar style changes #7880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
eui+/7865-sidebar-design-changes
branch
from
22f0b31
to
f19c671
Compare
mgadewoll
force-pushed
the
eui+/7865-sidebar-design-changes
branch
from
f19c671
to
dc3d894
Compare
tkajtoch
approved these changes
Jul 17, 2024
- adds temporary solution to render content only after mount to prevent noticable style updates from SSR to client side styles
- we prevent the styles update flash by hiding the content instead of not rendering it
mgadewoll
force-pushed
the
eui+/7865-sidebar-design-changes
branch
from
dc3d894
to
8fe3164
Compare
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7865
Note
This PR includes changes that were already done in this previous PR as the changes were required to ensure proper development. Once the previous PR is merged this current PR will be rebased.This PR is up-to-date and only includes new changes.Changes
Root.tsxcontent only after mount to prevent Emotion styles popping in after the Docusaurus SSR styles and causing noticable layout shiftsNote
There are slight differences between implementation and the available initial design for the desktop navigation sidebar. The design shows decorative status lines for nested nav items, but it's not clear from the designs what the logic is for those as it's only added for a single category.
After aligning with Design, we decided to exclude this style (at least until decided otherwise)
Screenshots
QA