Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize error messages before capturing them #80

Closed
simitt opened this issue Nov 21, 2023 · 3 comments · Fixed by #92
Closed

Sanitize error messages before capturing them #80

simitt opened this issue Nov 21, 2023 · 3 comments · Fixed by #92
Assignees

Comments

@simitt
Copy link

simitt commented Nov 21, 2023

The go-docappender logs ES error.reason for troubleshooting purposes. Before logging, the part potentially containing preview data - Preview of field's value: '%s'- should be removed; see ES code

Example: https://github.com/elastic/go-docappender/blob/main/appender.go#L312-L319

@jkakavas
Copy link
Member

@simitt is this resolved in 7.x too or isn't this a consideration/problem for that version ?

@simitt
Copy link
Author

simitt commented Jan 26, 2024

@marclop can you check if that behavior is the same in 7.17 please?

@marclop
Copy link
Contributor

marclop commented Jan 29, 2024

@simitt 7.17 uses the beats output, so as long as the beats team has fixed this issue for the libbeat 7.17 branch, it's not an issue for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants