Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix condition on community_id processor #4074

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

gsantoro
Copy link
Contributor

@gsantoro gsantoro commented Aug 26, 2022

What does this PR do?

Fix a if condition on the community_id processor on one of the ingest pipeline of the Traefik integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Check that ingest pipeline tests are passing

How to test this PR locally

cd packages/traefik && elastic-package test pipeline -v

@gsantoro gsantoro added the bug Something isn't working label Aug 26, 2022
@gsantoro gsantoro self-assigned this Aug 26, 2022
@gsantoro gsantoro requested a review from a team as a code owner August 26, 2022 10:48
@elasticmachine
Copy link

elasticmachine commented Aug 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-26T11:01:51.274+0000

  • Duration: 18 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@muthu-mps muthu-mps self-requested a review August 26, 2022 11:11
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 2.89
Classes 100.0% (3/3) 💚 2.89
Methods 100.0% (26/26) 💚 10.377
Lines 97.696% (212/217) 👍 5.948
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsantoro gsantoro merged commit 0d92849 into elastic:main Aug 30, 2022
@gsantoro gsantoro deleted the feature/traefik_community_id_fix branch August 30, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants