Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_meraki: improve handling of flows events #4352

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Sep 30, 2022

What does this PR do?

Simplify the handling of the line by using grok from the outset, reducing the number of machines needing to be instantiated and increasing the flexibility of the inputs that can be parsed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Sep 30, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-12T00:47:54.346+0000

  • Duration: 18 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review September 30, 2022 06:06
@efd6 efd6 requested a review from a team as a code owner September 30, 2022 06:06
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Sep 30, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚 2.496
Classes 100.0% (9/9) 💚 2.496
Methods 100.0% (62/62) 💚 9.668
Lines 98.8% (1070/1083) 👍 7.163
Conditionals 100.0% (0/0) 💚

Simplify the handling of the line by using grok from the outset,
reducing the number of machines needing to be instantiated and
increasing the flexibility of the inputs that can be parsed.
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Cisco Meraki
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic-Agent [Cisco Meraki] doesn't correctly parse some logs
3 participants