Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elasticsearch] Forward active.only config to datastream config #6146

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented May 10, 2023

What does this PR do?

This PR fixes a bug caused by the fact that the active.only flag was not being forwarded to the index_recovery data stream configuration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test

  • Pull this branch
  • run elastic-package stack up
  • cd packages/elasticsearch && elastic-package service up
  • Toggle the "Fech active index only" flag
image
  • When on, there shouldn't be any docs with stage: DONE in metrics-elasticsearch.stack_monitoring.index_recovery-* index
  • When off there will be docs with stage: DONE

Related issues

closes #5466

@crespocarlos crespocarlos requested a review from a team as a code owner May 10, 2023 12:52
@elasticmachine
Copy link

elasticmachine commented May 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-10T17:42:04.535+0000

  • Duration: 30 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 0
Total 60

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 87.5% (98/112) 👍 54.167
Lines 91.98% (562/611) 👎 -8.02
Conditionals 100.0% (0/0) 💚

@crespocarlos crespocarlos added bug Something isn't working Integration:Elasticsearch Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services v8.9.0 and removed v8.9.0 labels May 10, 2023
Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@crespocarlos crespocarlos merged commit 02afa89 into elastic:main May 23, 2023
3 checks passed
@crespocarlos crespocarlos deleted the 5466-elasticsearch-forward-ative_only-config branch May 23, 2023 13:15
@elasticmachine
Copy link

Package elasticsearch - 1.7.3 containing this change is available at https://epr.elastic.co/search?package=elasticsearch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Elasticsearch Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[elasticsearch] index_recovery.active_only variable is ignored
3 participants