Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Broken google_scc docs #6918

Closed
colleenmcginnis opened this issue Jul 11, 2023 · 2 comments · Fixed by #6921
Closed

[docs] Broken google_scc docs #6918

colleenmcginnis opened this issue Jul 11, 2023 · 2 comments · Fixed by #6921
Labels

Comments

@colleenmcginnis
Copy link
Contributor

In the Google Security Command Center integration (added in #6645), the description of the google_scc.finding.access.service_account.delegation_info.principal.subject field has an unclosed {, which is breaking the docs build. No integration docs updates will be published until this is resolved here and the changes are available on EPR.

description: A string representing the principalSubject associated with the identity. As compared to principalEmail, supports principals that aren't associated with email addresses, such as third party principals. For most identities, the format will be principal://iam.googleapis.com/{identity pool name}/subject/{subject) except for some GKE identities (GKE_WORKLOAD, FREEFORM, GKE_HUB_WORKLOAD) that are still in the legacy format serviceAccount:{identity pool name}[{subject}].

To fix this, this part of the description needs to be updated:

- principal://iam.googleapis.com/{identity pool name}/subject/{subject)
+ principal://iam.googleapis.com/{identity pool name}/subject/{subject}

cc @bmorelli25 @janvi-elastic @elastic/security-external-integrations

@jamiehynds
Copy link

@piyush-elastic @janvi-elastic can we get this addressed ASAP as it's blocking all new integration docs for being published.

@elasticmachine
Copy link

Package google_scc - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=google_scc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants