Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to windows package #77

Closed
17 tasks
narph opened this issue Jun 15, 2020 · 6 comments
Closed
17 tasks

Add metrics to windows package #77

narph opened this issue Jun 15, 2020 · 6 comments
Assignees
Labels
Integration:Windows integration Label used for meta issues tracking each integration Team:Integrations Label for the Integrations team v7.11.0

Comments

@narph
Copy link
Contributor

narph commented Jun 15, 2020

There's currently a windows package containing modules migrated from winlogbeat. The goal of this issue is to migrate the metrics datasets from the metricbeat windows module.

Package / Dataset creation or update checklist

This checklist is intended for Devs which create or update a package to make sure they are consistent.

  • Required Kibana version set to target version: 7.11.0

All Changes

  • Change follows development guidelines
  • Supported versions of the subject being monitored are documented
  • Supported operating systems are documented (if applicable)
  • System tests exist
  • Documentation
  • Fields follow ECS and naming conventions
  • At least a manual test with ES / Kibana / Agent has been performed.
  • The required Kibana version is set to the lowest version used in the manual test.

Dashboards

  • Dashboards exists (if applicable)
  • Screenshots of added / updated dashboards
  • Datastream filters added to visualizations

Log datasets

  • Pipeline tests exist (if applicable)
  • Test log files exist for the grok patterns
  • Generated output for at least 1 log file exists

Metric datasets

This entry is currently recommended. It will be mandatory once we provide better support for it.

  • Sample event (sample_event.json) exists

New Packages

  • Screenshot of the Fleet "Add Integration" Page.
@narph narph added integration Label used for meta issues tracking each integration Team:Integrations Label for the Integrations team labels Jun 15, 2020
@narph narph self-assigned this Jun 15, 2020
@narph narph assigned narph and unassigned narph Jun 30, 2020
@mtojek
Copy link
Contributor

mtojek commented Oct 28, 2020

I think we can close this one.

@mtojek mtojek closed this as completed Oct 28, 2020
@narph
Copy link
Contributor Author

narph commented Oct 28, 2020

I think we planned to tackle this in 7.11 or close future, is this still the case @andresrc ?

@mtojek mtojek reopened this Oct 28, 2020
@mtojek
Copy link
Contributor

mtojek commented Oct 28, 2020

Sorry, I understood that the scope of this task is covered.

@andresrc
Copy link
Collaborator

Hi, yes, I'm waiting for #342 to start creating the issues for 7.11. Leave this open, I will reuse it and update the content. Thanks

@elasticmachine
Copy link

Pinging @elastic/integrations-platforms (Team:Platforms)

@andresrc andresrc changed the title Migrate windows package Add metrics to windows package Oct 30, 2020
@masci masci added the v7.11.0 label Nov 25, 2020
@narph
Copy link
Contributor Author

narph commented Jan 14, 2021

will close this as metrics have been added and open migrate windows package issue

@narph narph closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:Windows integration Label used for meta issues tracking each integration Team:Integrations Label for the Integrations team v7.11.0
Projects
None yet
Development

No branches or pull requests

5 participants