Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cisco FTD] Pipeline Error when FTD Suffix is empty string #9241

Closed
agmic opened this issue Feb 26, 2024 · 2 comments · Fixed by #9541
Closed

[Cisco FTD] Pipeline Error when FTD Suffix is empty string #9241

agmic opened this issue Feb 26, 2024 · 2 comments · Fixed by #9541
Assignees
Labels
bug Something isn't working Integration:CiscoFTD Cisco FTD Firepower Threat Defense Team:Security-Deployment and Devices Deployment and Devices Security team

Comments

@agmic
Copy link

agmic commented Feb 26, 2024

I have the following logs in our environment which raise a pipeline error because the optional ftd suffix is an empty string.

<166>:Feb 26 11:26:52 UTC: %FTD--6-852002: Received Full Proxy to Lightweight event from application Snort for TCP flow 10.10.10.10/710 to 11.22.33.44/47873

Without suffix: %FTD-6-852002 : No error
With suffix: %FTD-ABCD-6-852002 : No error, suffix parsed to cisco.ftd.suffix
With blank suffix: %FTD--6-852002 : Pipeline error further down in pipeline as message ID (852002) is not parsed out.

The existing pipeline checks for a suffix, but expects something to be there. If the suffix is empty, the pipeline errors.

The code in question is:

- "%{FTD_PREFIX}-(?:%{FTD_SUFFIX:_temp_.cisco.suffix}-)?%{NONNEGINT:event.severity:int}-%{POSINT:_temp_.cisco.message_id}?:?\\s*%{GREEDYDATA:message}"

My regex is not that strong, but can the grok be changed from
%{FTD_PREFIX}-(?:%{FTD_SUFFIX:_temp_.cisco.suffix}-)?%{NONNEGINT:event.severity:int}-%{POSINT:_temp_.cisco.message_id}?:?\s*%{GREEDYDATA:message}

to:

%{FTD_PREFIX}-(?:%{FTD_SUFFIX:_temp_.cisco.suffix}?-)?%{NONNEGINT:event.severity:int}-%{POSINT:_temp_.cisco.message_id}?:?\s*%{GREEDYDATA:message}

(addition of question mark after FTD_SUFFIX capture group) to account for this?

@jamiehynds jamiehynds added Integration:CiscoFTD Cisco FTD Firepower Threat Defense Team:Security-Deployment and Devices Deployment and Devices Security team labels Feb 27, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@taylor-swanson taylor-swanson added the bug Something isn't working label Mar 4, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this Apr 8, 2024
@elasticmachine
Copy link

Package cisco_ftd - 3.2.3 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:CiscoFTD Cisco FTD Firepower Threat Defense Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants