Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding metadata when creating an API key #100534

Closed
bytebilly opened this issue May 25, 2021 · 6 comments · Fixed by #100682
Closed

Allow adding metadata when creating an API key #100534

bytebilly opened this issue May 25, 2021 · 6 comments · Fixed by #100682
Assignees
Labels
enhancement New value added to drive a business result Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@bytebilly
Copy link
Contributor

Context

Users can create API keys in Stack Management > API keys, specifying the name, permissions, and the expiration date.
With Elasticsearch 7.13, now API keys can have metadata attached to them.

Proposal

Improve the Create API key panel to include metadata.
Since metadata may be arbitrary data, we could use an approach similar to what we already do for permissions, a textbox where users will enter their own values.

This is a possible mockup of the final result:
image

@bytebilly bytebilly added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result labels May 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@bytebilly
Copy link
Contributor Author

cc @arisonl @cristina-eleonora

@legrego
Copy link
Member

legrego commented May 25, 2021

Related: #93820

@thomheymann thomheymann self-assigned this May 25, 2021
@cristina-eleonora
Copy link

It looks good to me 👍🏻

@legrego
Copy link
Member

legrego commented May 26, 2021

@bytebilly I think it deserves a separate issue/story, but we should explore if/how we want to display this metadata when viewing API Keys (not just creating).

@bytebilly
Copy link
Contributor Author

I think it deserves a separate issue/story, but we should explore if/how we want to display this metadata when viewing API Keys (not just creating).

Agreed, I would consider it in the scope of the general UX review of the API key table, along with other improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants