Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index pattern creation UX: Simplify index-pattern creation form #10444

Closed
cjcenizal opened this issue Feb 17, 2017 · 9 comments
Closed

Index pattern creation UX: Simplify index-pattern creation form #10444

cjcenizal opened this issue Feb 17, 2017 · 9 comments
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Feb 17, 2017

Remove "Index contains time-based events" checkbox

#11419 (merged)

index_pattern_form

Per @skearns64, we can remove this checkbox and just provide a "Don't use time field" option in the dropdown.

Remove "Expand index pattern when searching" checkbox

screen shot 2017-04-11 at 10 13 39 am

Remove UI for creating index patterns based on event times

image

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. :Management labels Feb 17, 2017
@skearns64
Copy link

I wonder if we should be slightly more explicit with the label name - "Time Field" feels a bit ambiguous - I may have several date fields in my index. I find "Default Time Field" to be a little more intuitive - this is the time field that will be used by default for this index pattern.

If we do change the label to "Default Time Field", then we should think through what the first entry in the dropdown should be - maybe something like "No Default Time Field"

@uboness
Copy link

uboness commented Feb 17, 2017

"Default Time Field" or another option can be "Time Filter Field" (which basically describes what its used for) ?

Also, we can even be a bit smarter and if there is not time field for the defined pattern, the dropdown remains disabled and shows nothing.

Also, very important IMO, one of the problems you have today, is that it may take quite some time between the time the user enters the index pattern to the time we resolve all the optional time fields and populate the dropdown. Today there's no indication that this is being processed in the background, and further more, with this change, it'll be even harder to know if a) the entered index pattern simply doesn't have a time field, or b) it's still working on resolving the fields. We should add a spinner next to the dropdown (on its right) that will spin as long as we're resolving the fields.

@cjcenizal
Copy link
Contributor Author

@uboness see #10439 re spinner and loading feedback.

@uboness
Copy link

uboness commented Feb 17, 2017

@uboness see #10439 re spinner and loading feedback.

ha... perfect

@skearns64
Copy link

Also, we can even be a bit smarter and if there is not time field for the defined pattern, the dropdown remains disabled and shows nothing.

I personally prefer the consistency of having the "Default Time Field" dropdown to always have the same value when it means the same thing. If I have an index with no date fields, I would want to see the dropdown (disabled or enabled doesn't matter) saying "No Default Time Field". If I do have date fields, I would want the first item in the dropdown to always be "No Default Time Field", so if I choose to have no default date field, it looks the same.

@uboness
Copy link

uboness commented Feb 18, 2017

I personally prefer the consistency of having the "Default Time Field" dropdown to always have the same value when it means the same thing. If I have an index with no date fields, I would want to see the dropdown (disabled or enabled doesn't matter) saying "No Default Time Field". If I do have date fields, I would want the first item in the dropdown to always be "No Default Time Field", so if I choose to have no default date field, it looks the same.

I'm good with that too... as long as we keep the dropdown disabled if there's not even one date field

@cjcenizal cjcenizal changed the title Index pattern creation UX: Remove "Index contains time-based events" checkbox Index pattern creation UX: Simplify index-pattern creation form Apr 21, 2017
@cjcenizal
Copy link
Contributor Author

cjcenizal commented Apr 21, 2017

Per conversation with @ycombinator, we're going to aim to get this in for 6.0.

We will not implement the "3 form solution" (#10026).

Before moving forward with this issue, we need to ensure that users won't miss the functionality that the "Expand index pattern when searching" checkbox provides, or be impacted performance-wise. Review concerns raised by @Bargs and @epixa in:

@epixa
Copy link
Contributor

epixa commented Apr 24, 2017

I don't think there is any way to tell for sure whether people will miss that functionality or not, but I do think it's too early to say one way or another. Given our past experience with changes in this area, I don't think we can realistically remove the field_stats behavior entirely in 6.0, though we should deprecate it. Starting in 5.4.0, the field_stats behavior is no longer the default option for new index patterns, so deprecating it is the logical next step.

@cjcenizal
Copy link
Contributor Author

I think everything in here has been addressed by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

4 participants