[Lens] Unnecessary data reload after saving Lens as new

[tsullivan]

Kibana version: 7.14.0=bc1

Elasticsearch version:

Server OS version:

Browser version: Chrome 91

Browser OS version: Linux

Original install method (e.g. download page, yum, from source, etc.): Docker

Describe the bug:

After editing a Lens chart and saving it as a new chart, all the data in the UI is cleared out and gets reloaded from the search. This should not happen since the search didn't change.

This doesn't happen when saving to the same Lens.

Performance issue: in a slow network, loading data can take a long time, even if its being loaded from a search session.

Steps to reproduce:
From Dashboard:

1. Edit a Lens from a Dashboard
2. Click "Save as", do not choose "Add to Dashboard after saving", then Save.
3. The data is reloaded from search, but the search has not changed since before saving.

From Visualize Editor:

1. Create a Lens or open a saved Lens
2. If it's new, simply add some data and Save
3. If it's an existing, click Save and choose "Save as new Lens visualization"

Expected behavior:
The search did not change, so the data should not be reloaded from search.

Screenshots (if relevant):

Reloading the data from search causes everything on the page to flash away at 0:44:
https://user-images.githubusercontent.com/908371/124845405-88776780-df4b-11eb-9b81-57e1af87a822.mp4

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[flash1293]

Maybe we can resolve this easily once the state management refactoring is done

[flash1293]

When fixing this, make sure switching SOs via global search still works.

[stratoula]

This has been fixed, closing this