Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] [8.0] Prepare for making alerting saved objects sharecapable #107084

Closed
chrisronline opened this issue Jul 28, 2021 · 2 comments · Fixed by #109990
Closed

[Alerting] [8.0] Prepare for making alerting saved objects sharecapable #107084

chrisronline opened this issue Jul 28, 2021 · 2 comments · Fixed by #109990
Assignees
@YulNaumenko
Labels
enhancement New value added to drive a business result estimate:small Small Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
Kibana Alerting

Comments

@chrisronline
Copy link
Contributor

chrisronline commented Jul 28, 2021 •
edited
Loading

Related to #107069

To prepare for shareable saved objects in 8.0, we need to make two changes that can only go into 8.0:

  • Change all saved objects created by the alerting plugin to use namespaceType: 'multiple-isolated' (instead of namespaceType: 'single')
  • Add an ESO migration for 8.0

Because we are able to get the current Kibana version from core, we might be able to create a single set of backportable changes that work in both environments. If this is not feasible, this change can only go into master.

See the PoC PR for more insight into how this might work.
@chrisronline chrisronline added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types labels Jul 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@chrisronline chrisronline added this to To-Do (Ordered by priority) in Kibana Alerting Jul 28, 2021
@chrisronline chrisronline mentioned this issue Jul 28, 2021
Closed
@chrisronline chrisronline self-assigned this Aug 2, 2021
@chrisronline chrisronline moved this from To-Do (Ordered by priority) to In Progress in Kibana Alerting Aug 2, 2021
@chrisronline chrisronline changed the title [Alerting] [8.0] Convert all savedObjectClient.get() calls to use savedObjectClient.resolve and handle the response appropriately [Alerting] [8.0] Prepare for making alerting saved objects sharecapable Aug 2, 2021
@chrisronline chrisronline mentioned this issue Aug 2, 2021
Closed
@chrisronline chrisronline moved this from In Progress to In Review in Kibana Alerting Aug 2, 2021
@mikecote mikecote moved this from In Review to To-Do (Ordered by priority) in Kibana Alerting Aug 9, 2021
@mikecote mikecote added loe:small Small Level of Effort loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Aug 9, 2021
@chrisronline chrisronline mentioned this issue Aug 10, 2021
Closed
@gmmorris gmmorris removed the Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types label Aug 11, 2021
@ymao1
Copy link
Contributor

ymao1 commented Aug 12, 2021

It would be nice to add a functional test that mimics the verification steps from this PR. Perhaps use esArchiver to load pre-8.0 rules and navigate to the rule details page to test for the redirect and toaster popup.

@ymao1 ymao1 mentioned this issue Aug 12, 2021
Merged
1 task
@gmmorris gmmorris added the enhancement New value added to drive a business result label Aug 13, 2021
@gmmorris gmmorris added the estimate:small Small Estimated Level of Effort label Aug 18, 2021
@YulNaumenko YulNaumenko moved this from To-Do (Ordered by priority) to In Progress in Kibana Alerting Aug 24, 2021
@YulNaumenko YulNaumenko self-assigned this Aug 24, 2021
@YulNaumenko YulNaumenko mentioned this issue Aug 25, 2021
Merged
@YulNaumenko YulNaumenko moved this from In Progress to In Review in Kibana Alerting Aug 25, 2021
@YulNaumenko YulNaumenko linked a pull request Aug 25, 2021 that will close this issue
[Alerting] [8.0] Prepare for making alerting saved objects sharecapable #109990
Merged
@YulNaumenko YulNaumenko mentioned this issue Aug 27, 2021
Merged
1 task
Kibana Alerting automation moved this from In Review to Done (Ordered by most recent) Aug 31, 2021
@gmmorris gmmorris removed the loe:medium Medium Level of Effort label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YulNaumenko YulNaumenko

Labels
enhancement New value added to drive a business result estimate:small Small Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Kibana Alerting
Done (Ordered by most recent)
Milestone
No milestone
7 participants
@chrisronline @gmmorris @kobelb @mikecote @ymao1 @elasticmachine @YulNaumenko