Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Alerts] Add tests for changes in the schema #110798

Open
Tracked by #165878 ...
banderror opened this issue Sep 1, 2021 · 5 comments
Open
Tracked by #165878 ...

[Security Solution][Alerts] Add tests for changes in the schema #110798

banderror opened this issue Sep 1, 2021 · 5 comments
Labels
Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture Theme: rac label obsolete

Comments

@banderror
Copy link
Contributor

Parent ticket: #101016
Related to: #109293

Summary

(Immediately after 7.15.0)

Add tests that compare the 7.15 shipped schema to the 7.16+ schema in development to ensure that the existing schema can be upgraded properly.

Ideas:

  • there would be 1 test per 1 index (or in different words per rule registry client calling ruleDataService.initializeIndex())
  • the tests would compare actual resulting schema (or index template) with a snapshot
  • these tests could be in their own separate folder
  • we could set certain CODEOWNERS for this folder

Background

The background for this is our discussions with @kobelb (see #109276 (comment) and above comments) on the "compatibility" of the current index upgrade logic with the ideas for backwards compatibility (#109293).

@banderror banderror added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: rac label obsolete labels Sep 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror
Copy link
Contributor Author

Hey everyone, I removed this ticket from the backlog of the Detection Rules area. We (@elastic/security-detections-response-rules) are not the owners anymore (however feel free to still ping us if you have any tech questions about the ticket).

Ownership of this ticket and other tickets related to rule_registry (like #101016) now goes to the Detection Alerts area (Team:Detection Alerts label). Please ping @peluja1012 and @marshallmain if you have any questions.

@peluja1012 peluja1012 added the technical debt Improvement of the software architecture and operational architecture label Oct 26, 2021
@marshallmain marshallmain changed the title [RAC][Rule Registry] Add tests for changes in the schema [Security Solution][Alerts] Add tests for changes in the schema Apr 19, 2022
@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Detection Alerts Security Detection Alerts Area Team labels May 13, 2023
@yctercero
Copy link
Contributor

Can we close this out as we're moving to OpenAPI? @marshallmain @banderror

@marshallmain
Copy link
Contributor

I think this is for the alerts schema rather than the rules schema but with no recent action on it or planned action I'd be fine with closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture Theme: rac label obsolete
Projects
None yet
Development

No branches or pull requests

5 participants