Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Synchronize cursor Popup for X-axis across all Lens visualizations in a dashboard #113719

Closed
Tracked by #57712
matschaffer opened this issue Oct 4, 2021 · 12 comments · Fixed by #130449
Closed
Tracked by #57712
Assignees
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Feature:Lens Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@matschaffer
Copy link
Contributor

Description of feature

#77530 introduced a synchronized cursor position for all Lens graphs in a dashboard.

This is a great step forward, but it'd be also good to have (possibly configurable) synchronized popups as well.

Internet_speeds_-_Elastic

Without the popups, the best a viewer can do is visually guess at the likely Y axis value for a given point.

This is okay for one or two lines, but would definitely get more challenging as more lines appear on the graph, or if the point of interest is a subtle change relative to the Y-axis scale.

@matschaffer matschaffer added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ghudgins
Copy link

@flash1293 - @elastic/datavis wants the redesign of the tooltip elastic/elastic-charts#615 before we enable this. We're going to need to do this soon regardless because of some of the other 8.x plans.

@matschaffer
Copy link
Contributor Author

As an additional data point I noticed recently that you can also lose the lens cursor depending on your mouse position on the X axis.

This really confused me for a bit when I handed on a "bad" mouse point by accident and was surprised to not see the cursor on the other graph.

Here's a recording where you can see the shared cursor only kicking in when I'm (I think) near the bucket start then disappearing when I move off it a little while the popup and point circle remain.

@stratoula
Copy link
Contributor

@flash1293 - @elastic/datavis wants the redesign of the tooltip elastic/elastic-charts#615 before we enable this. We're going to need to do this soon regardless because of some of the other 8.x plans.

@ghudgins also I think that the pie tooltip redesign elastic/elastic-charts#623 can be considered as a blocker for the removal of the vislib pie.

@flash1293
Copy link
Contributor

flash1293 commented Oct 21, 2021

@matschaffer Thanks for reporting this - it seems like the cursor is hidden behind the grid line. I think it's this bug which is already in the process of getting fixed: elastic/elastic-charts#1283 cc @markov00

@stratoula
Copy link
Contributor

@flash1293 @ghudgins this setting is going to be off or on by default?

@markov00
Copy link
Member

markov00 commented Apr 19, 2022

IMHO this should be off by default (1st because of the breaking change in the UX, 2nd to due to the high increase of noise in the dashboard UX where suddenly all the charts now are showing tooltip "flags" all-around creating a very noisy experience, consider that we also got some users asking to remove completely the tooltip to avoid such noise when exploring a dashboard).
This configuration should contain 3 options:

  1. no sync (only the chart with the mouse over it will show the tooltip)
  2. sync only the cursor (the current chart will show the tooltip, all the others just the cursor)
  3. sync and show tooltip everywhere.

I'm saying that because in some cases, like in TSVB and in Timelion, the legend already reflects the value of the current cursor (independently from the fact that the cursor is the original one or the synched one) so in this case, you don't really need the tooltip "flags" moving around on every chart to replicate the same information you already have on the legend.

@stratoula
Copy link
Contributor

@markov00 yes I agree with being off by default tbh. This is how I implemented it I just wanted to be certain that this is what we agreed on our planning.

About the second one sync only the cursor (the current chart will show the tooltip, all the others just the cursor). This feature already exists, it is always on and there is no switch to close it.

Is this something that we want to change?

@markov00
Copy link
Member

markov00 commented Apr 19, 2022

About the second one sync only the cursor (the current chart will show the tooltip, all the others just the cursor). This feature already exists, it is always on and there is no switch to close it.

I know, I was only listing what, in my opinion, should be the capabilities available at the dashboard level. point 2 is what it is today, point 3 is what you have added, point 1 is an interesting option that is currently not available, but available by our competitors

@ghudgins
Copy link

I agree with @markov00 - keep defaults as they are today. Performance being another motivation to add to his list.

no sync (only the chart with the mouse over it will show the tooltip)

if it's easy I agree this could be valuable (a user who doesn't want any distraction, a user who wants optimal browser performance). Feels like we should make an issue for it though to give it a bit of thought

@stratoula
Copy link
Contributor

stratoula commented Apr 19, 2022

Yes I think that is needs to be discussed as the current behavior of the cursor sync is always on and cant be turned off. Turning it off by default will be a change in the current behavior so I can create a discuss issue for this tomorrow.

For the current issue we are going to handle the 3rd one sync and show tooltip everywhere. with the default state set to false.

Dashboard automation moved this from Inbox to Done May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Feature:Lens Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Dashboard
  
Done
Lens
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants