Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Improve tests for xpack.fleet.agentPolicies preconfiguration #115044

Closed
1 of 3 tasks
joshdover opened this issue Oct 14, 2021 · 4 comments · Fixed by #130300
Closed
1 of 3 tasks

[Fleet] Improve tests for xpack.fleet.agentPolicies preconfiguration #115044

joshdover opened this issue Oct 14, 2021 · 4 comments · Fixed by #130300
Assignees
@nchaulet
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture tests_needed

Comments

@joshdover
Copy link
Contributor

joshdover commented Oct 14, 2021 •
edited by nchaulet
Loading

Follow up to #115030

In #114011, we introduce a regression in the preconfiguration feature that is used by Cloud. This wasn't caught by any of our automation test which we should always be able to detect.

Tests to add:

  • Functional test that emulates starting a clean Kibana & ES with the same configuration we use on Cloud and verifies that setup completes successfully [Fleet] Add integration test for the cloud policy #126605
  • Test that add a preconfigured APM to an existing Kibana instance
  • Test that add an id to a package without id
@joshdover joshdover added tests_needed technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@joshdover joshdover changed the title [Fleet] Improve functional tests for xpack.fleet.agentPolicies functionality ("preconfiguration") [Fleet] Improve tests for xpack.fleet.agentPolicies preconfiguration Feb 28, 2022
@joshdover
Copy link
Contributor Author

@nchaulet would you be able to add any additional tests you know we're missing to the list above? I know we've had some bugs around changes to policy names and ids, but I'm not sure what coverage we're still missing in this area.

@nchaulet
Copy link
Member

Yes I can add these tests they will be very similar to the one I wrote for the reset preconfiguration API 👍

@nchaulet nchaulet self-assigned this Feb 28, 2022
@joshdover
Copy link
Contributor Author

Related to #126492

@nchaulet nchaulet mentioned this issue Mar 1, 2022
Merged
@nchaulet nchaulet mentioned this issue Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nchaulet nchaulet

Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture tests_needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Improve Fleet preconfiguration tests nchaulet/kibana
3 participants
@nchaulet @joshdover @elasticmachine