Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fetch full visualization SO when visiting listing page #118144

Open
flash1293 opened this issue Nov 10, 2021 · 1 comment
Open

Do not fetch full visualization SO when visiting listing page #118144

flash1293 opened this issue Nov 10, 2021 · 1 comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Similar to #118143

Currently the visualize library listing page is using the following URL to fetch visualizations for listing them: /api/saved_objects/_find?default_search_operator=AND&has_reference=%5B%5D&page=1&per_page=1000&search_fields=title%5E3&search_fields=description&type=lens&type=visualization

This returns all attributes of the saved objects which can sum up pretty quickly with complex visualizationslike vega.

Only fields required to display the listing page should be fetched. As the visualization "type" is part of the stringified JSON this is not a trivial change and requires migration, but it should be extracted to a separate field so only title and type can be requested.

@flash1293 flash1293 added performance Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jan 25, 2023
@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants