Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Replace usages of <FormattedMessage> with i18n.translate #119049

Open
gbamparop opened this issue Nov 18, 2021 · 1 comment
Open

[APM] Replace usages of <FormattedMessage> with i18n.translate #119049

gbamparop opened this issue Nov 18, 2021 · 1 comment
Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@gbamparop
Copy link
Contributor

gbamparop commented Nov 18, 2021 •
edited

Both i18n.translate and <FormattedMessage> can handle string constants and strings with parameters. We are using both ways in the codebase which seem to have the same output.

In most cases <FormattedMessage> can be replaced with i18n.translate.
@gbamparop gbamparop added the Team:APM All issues that need APM UI Team support label Nov 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@gbamparop gbamparop added good first issue low hanging fruit [zube]: Inbox technical debt Improvement of the software architecture and operational architecture labels Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dannycroft @sorenlouv @gbamparop @elasticmachine