Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow KibanaThemeProvider to be used in preboot plugins #119204

Open
jportner opened this issue Nov 19, 2021 · 1 comment
Open

Allow KibanaThemeProvider to be used in preboot plugins #119204

jportner opened this issue Nov 19, 2021 · 1 comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@jportner
Copy link
Contributor

jportner commented Nov 19, 2021

While implementing #119124, I realized that the interactive_setup plugin cannot have a dependency on the kibana_react plugin, because the former is a "preboot" plugin and the latter is a "standard" plugin.

I decided to copy the KibanaThemeProvider code to the interactive_setup plugin as a short-term solution. However, we should come up with a way to remove this duplication in the future.

At a high level I can see a couple of viable options:

  1. Move the KibanaThemeProvider to a package (e.g., @kbn/theme-provider).
  2. Change the PluginsService to allow a "preboot" plugin to require a "standard" plugin's bundle, and change the Server, RenderingService, and bootstrapRendererFactory to provide a subset of "standard" bundles while in "preboot" mode. This sounds more complex, but it might be better long-term as we eventually add more "preboot" plugins and add more dependencies from other places in Kibana.

More context is in my comment here: #119124 (comment)

@jportner jportner added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Nov 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants