[UA] Increase robustness around ES deprecation message parsing #119834
Labels
enhancement
New value added to drive a business result
Feature:Upgrade Assistant
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
When reviewing #119745 I realised that we have a logic in place to enhance the deprecation by parsing the string message returned by ES. It seems that this area of the code is bridle as our server side
getCorrectiveAction
method does not have API integration tests around it. We wouldn't be alerted of regression in the UI whenever ES decides to update their message.In the linked PR we can see that there are 2 places with the same logic to detect if the deprecation message is related to ML (
return /[Mm]odel snapshot/.test
), I think it would be good to centralise the parsing logic in a single place and add comments. Ideally we would receive meta data from ES, but meanwhile we use regex to parse a string and enhance the deprecations it would be good to do it in a single place.The text was updated successfully, but these errors were encountered: