Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Increase robustness around ES deprecation message parsing #119834

Open
sebelga opened this issue Nov 29, 2021 · 2 comments
Open

[UA] Increase robustness around ES deprecation message parsing #119834

sebelga opened this issue Nov 29, 2021 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@sebelga
Copy link
Contributor

sebelga commented Nov 29, 2021

When reviewing #119745 I realised that we have a logic in place to enhance the deprecation by parsing the string message returned by ES. It seems that this area of the code is bridle as our server side getCorrectiveAction method does not have API integration tests around it. We wouldn't be alerted of regression in the UI whenever ES decides to update their message.

In the linked PR we can see that there are 2 places with the same logic to detect if the deprecation message is related to ML (return /[Mm]odel snapshot/.test), I think it would be good to centralise the parsing logic in a single place and add comments. Ideally we would receive meta data from ES, but meanwhile we use regex to parse a string and enhance the deprecations it would be good to do it in a single place.

@sebelga sebelga added enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Nov 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@alisonelizabeth
Copy link
Contributor

Ideally we would receive meta data from ES

Agreed. I found a similar bug caused by changed deprecation messages in #123501. ES did add this capability to an extent via elastic/elasticsearch#73089, but would likely need to build upon this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants