Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Elastic Agent: Add option to create APM agent keys in context of configuring an integration #121266

Open
formgeist opened this issue Dec 15, 2021 · 4 comments
Labels
apm:onboarding discuss enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

formgeist commented Dec 15, 2021

Summary

Since we've added a UI around creating APM agent keys for authentication between APM server (Integration) and APM agents, we should consider showing an option to create keys directly within the integration as the user is configuring authentication. There are two proposals for how to support this UX.

Proposal A: Link to APM agent keys in Settings

This is the minimal effort option to add a button link to the APM agent keys management view in Settings and to allow users to create keys there and then go back to continue the integration setup.

The proposed flow is;

  • The user is configuring the APM integration
  • Enables the "API key for agent authentication"
  • Option to "Create APM agent key" is displayed
  • Clicks the button link to go to the Agent Keys view in APM Settings (preferably in a new window not to loose changes)
  • User creates a new key and copies the key to be configured in their APM agent
  • User returns to complete the integration configuration
CleanShot.2021-12-15.at.09.32.36.mp4

▶️ Figma prototype

Proposal B: Offer in-context option to create agent key(s)

Another option is to provide an option to create keys in the context of setting up the integration which won't move the user out of the existing setup flow. After successfully creating a key, the key will be displayed in view for as long as they're viewing the current state. There's another option for creating another key so the user can create more at a time.

The proposed flow is;

  • The user is configuring the APM integration
  • Enables the "API key for agent authentication"
  • Option to "Create APM agent key" is displayed
  • The create agent key flyout is shown and the user configures the key and saves it
  • The key is presented in view and can be copied to be configured in their agent
  • User returns to complete the integration configuration
CleanShot.2021-12-15.at.09.33.07.mp4

▶️ Figma prototype

@graphaelli @simitt @felixbarny @sqren Looking for your feedback on the above proposals and any questions or suggestions you might have to improve this?

@formgeist formgeist added discuss Team:APM All issues that need APM UI Team support labels Dec 15, 2021
@formgeist formgeist self-assigned this Dec 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@felixbarny
Copy link
Member

I didn't have a detailed look yet. But what comes to mind is that if an api key or secret token is configured, we have to pass that along when doing Java runtime attachment. This should be doable with the --config option in the attacher.

@formgeist
Copy link
Contributor Author

@felixbarny thanks - that's definitely worth noting.

I've updated the description with more detailed flows so it's easier to follow the flow of each proposal.

@simitt
Copy link
Contributor

simitt commented Dec 21, 2021

Both options look valid, of course the second option, where the apm api key creation is integrated and not directing the user to a different page would be even nicer.

@dannycroft dannycroft added the enhancement New value added to drive a business result label Feb 21, 2022
@formgeist formgeist removed their assignment May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:onboarding discuss enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

5 participants