Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Delete dead code getAddToCasePopover #125658

Closed
Tracked by #123183
academo opened this issue Feb 15, 2022 · 2 comments · Fixed by #127003
Closed
Tracked by #123183

[Cases] Delete dead code getAddToCasePopover #125658

academo opened this issue Feb 15, 2022 · 2 comments · Fixed by #127003
Assignees
@academo
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0

Comments

@academo
Copy link
Contributor

academo commented Feb 15, 2022

The following public method from the timelines plugin is dead code getAddToCasePopover and it contains calls to the useAddToCase hook that is currently on refactor.

To prevent confusions and reduce the refactor scope we should delete this dead code.
@academo academo added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.2.0 labels Feb 15, 2022
@academo academo self-assigned this Feb 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

This was referenced Feb 15, 2022
Closed
Merged
Merged
@academo academo mentioned this issue Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@academo academo

Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all cases related code from timelines academo/kibana
2 participants
@academo @elasticmachine