-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Maintain versions list for Agent upgrade modal #133309
Comments
Pinging @elastic/fleet (Team:Fleet) |
@kpollich I'm working on this issue and I basically have two options:
What do you think? Either way I think that we need some mechanism to keep the version list updated. |
It's pretty unfortunate that that API is somehow down while we need to figure this out 😅 Option number one doesn't sound ideal to me, because as soon as the product versions API goes down like it is now every Kibana PR will fail CI when our test runs. Depending on a network location like this during CI is generally going to introduce flakiness. Option number two is a bit better because we can say "we'll check the product versions API if possible, otherwise use a hardcoded list of versions," but then updating the hardcoded list becomes something that's maybe easier to forget about. |
Did we consider an option 3: a script that populate the list during Kibana build (similar to bundled packages)? we do not introduce flakyness in the UI if this endpoint is down or private network .... and we have an up to date version list |
Build task to write the product versions to a gitignored file would probably work well here, I like that idea @nchaulet |
Yes exactly, I think that we initially ruled out the idea of using this endpoint for production because of its slowness. @nchaulet actually I wasn't aware of this option :) could you send an example of it? I already have the code that filters out the fetched list, I just need to move it to the correct place. |
Thanks @nchaulet. I have a couple of questions about it:
|
No they are executed when building Kibana, or manually for local dev
Yes I think we probably need a new API to provide versions |
Follow up to #130259
The versions dropdown in the Agent upgrade modal is currently a static list. The main requirements are
The web team provided a public endpoint that lists all the available versions: https://www.elastic.co/api/product_versions
We have the following possible options:
GET /api/fleet/agents/available_upgrade_versions
This API should fetch data from theproduct_versions
endpoint and fallback to an hardcorded list to still provide options to air-gapped environments or when the data are not available.product_versions
endpoint and fails when a new version was release. This means maintaining the list manually, however the static list needs to be there anywayThe text was updated successfully, but these errors were encountered: