Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] Refactor error handling in alerting task runner #134579

Closed
Tracked by #124206
ymao1 opened this issue Jun 16, 2022 · 1 comment · Fixed by #139721
Closed
Tracked by #124206

[Response Ops] Refactor error handling in alerting task runner #134579

ymao1 opened this issue Jun 16, 2022 · 1 comment · Fixed by #139721
Assignees
@doakalexi
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Jun 16, 2022

We added stack traces for errors thrown in the alerting task runner in this PR. In the task runner, errors are caught and rethrown possibly multiple times so sometimes the original stack trace is lost. To get around that, we're logging errors from the rule executors in multiple places in order to capture the original stack trace. It would be nice to refactor this error logic so we can log in a single place while preserving the original stack trace.

Adding to meta issue
@ymao1 ymao1 mentioned this issue Jun 16, 2022
Closed
8 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 16, 2022
@ymao1 ymao1 added blocked Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework and removed needs-team Issues missing a team label labels Jun 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@doakalexi doakalexi self-assigned this Aug 29, 2022
@doakalexi doakalexi mentioned this issue Aug 30, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doakalexi doakalexi

Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Response Ops] [Alerting] Refactor error handling in alerting task runner doakalexi/kibana
3 participants
@ymao1 @elasticmachine @doakalexi