Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Rename "Calculation" to "Bucket Script" for consistency #13796

Closed
alexfrancoeur opened this issue Aug 31, 2017 · 5 comments
Closed

[TSVB] Rename "Calculation" to "Bucket Script" for consistency #13796

alexfrancoeur opened this issue Aug 31, 2017 · 5 comments
Assignees
Labels
Feature:TSVB TSVB (Time Series Visual Builder) PR sent Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@alexfrancoeur
Copy link

With the implementation of a new special aggregation that utilizes Math.js (#13681) around the corner, "Calculation" and "Math" may become confusing. To be consistent with Elasticsearch terminology, we should rename this function to "Bucket Script", as that's the type of aggregation we are actually using behind the scenes.

cc: @elastic/kibana-visualizations, @simianhacker

@alexfrancoeur alexfrancoeur added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Aug 31, 2017
@shaharmor
Copy link
Contributor

This has already been done, but the lookup tables have not been updated to mimic the change.

If you try to autocomplete bucket script, it will fail to complete you. The lookup table still uses calculation

@alexfrancoeur
Copy link
Author

Thanks @shaharmor! @simianhacker can we resolve this? What version did we end up changing the name?

@thomasneirynck
Copy link
Contributor

This seems this was done with #13681 correct? Please reopen if I'm off, thx!

@shaharmor
Copy link
Contributor

@thomasneirynck the lookup table is still not updated

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@alexwizp alexwizp assigned alexwizp and sulemanof and unassigned alexwizp Feb 15, 2019
@sulemanof
Copy link
Contributor

Working fine since the component changed to EuiComboBox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) PR sent Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

7 participants