Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move static code from visualizations and charts plugins into package #138723

Open
flash1293 opened this issue Aug 12, 2022 · 9 comments
Open

Move static code from visualizations and charts plugins into package #138723

flash1293 opened this issue Aug 12, 2022 · 9 comments
Labels
blocked impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects

Comments

@flash1293
Copy link
Contributor

There are a few shared helpers exposed by the visualizations and charts plugins. These should be moved into a package so they don't bloat the bundle size unnecessarily.

@flash1293 flash1293 added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293 flash1293 added this to 8.6 in Lens Sep 29, 2022
@stratoula
Copy link
Contributor

@flash1293 which exactly helpers do you have in mind here?

@Kuznietsov Kuznietsov self-assigned this Nov 2, 2022
@Kuznietsov
Copy link
Contributor

@flash1293, WDTY about moving these files from charts plugin to @kbn/coloring? Please, mark those you approve:

  • src/plugins/charts/common/static
  • src/plugins/charts/public/static/colors
  • src/plugins/charts/public/static/components
  • src/plugins/charts/public/services/palettes/lighten_color.ts

@flash1293
Copy link
Contributor Author

Good question both @stratoula and @Kunzetsov , should have clarified that. The stuff from charts sounds good, I went through visualizations but unfortunately a lot of that depends on types from app services plugins, so it's hard to move right now. Let's start with the charts stuff for now.

@Kuznietsov
Copy link
Contributor

@flash1293, about visualizations plugin, I couldn't find anything to be extracted out to the package. Could you, please, specify, which exactly helpers you want to move out? Thanks.

@flash1293
Copy link
Contributor Author

@Kunzetsov I wanted to move the "static code" block of exports:

export { TypesService } from './vis_types/types_service';
export { VISUALIZE_EMBEDDABLE_TYPE, VIS_EVENT_TO_TRIGGER } from './embeddable';
export { VisualizationContainer } from './components';
export { getVisSchemas } from './vis_schemas';

But it doesn't work yet because they depend on the data plugin. So we will need for that to be sorted out first.

@stratoula
Copy link
Contributor

Nice! Thanx you both, the above things sound as a good start for this charts oriented package!

@VladLasitsa
Copy link
Contributor

VladLasitsa commented Nov 9, 2022

Blocked due package structure not ready yet.

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Dec 20, 2022
@Kuznietsov Kuznietsov removed their assignment Jan 4, 2023
@markov00
Copy link
Member

We should move MULTI_FIELD_KEY_SEPARATOR and MULTI_FIELD_VALUES_SEPARATOR into a package from their current position: data-common plugin.
This is because the same constant duplicates in multiple place and needs to be accessed both from packages and from plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
Lens
  
8.6
Development

No branches or pull requests

6 participants