New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move static code from visualizations and charts plugins into package #138723
Comments
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@flash1293 which exactly helpers do you have in mind here? |
@flash1293, WDTY about moving these files from
|
Good question both @stratoula and @Kunzetsov , should have clarified that. The stuff from charts sounds good, I went through |
@flash1293, about |
@Kunzetsov I wanted to move the "static code" block of exports: kibana/src/plugins/visualizations/public/index.ts Lines 19 to 22 in f576b1f
But it doesn't work yet because they depend on the data plugin. So we will need for that to be sorted out first. |
Nice! Thanx you both, the above things sound as a good start for this charts oriented package! |
Blocked due package structure not ready yet. |
We should move |
There are a few shared helpers exposed by the
visualizations
andcharts
plugins. These should be moved into a package so they don't bloat the bundle size unnecessarily.The text was updated successfully, but these errors were encountered: