Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter div shown when a shared dashboard is embedded in an iFrame. (Kibana 5.5.2) #13894

Closed
snuids opened this issue Sep 7, 2017 · 9 comments
Assignees
Labels
Feature:Dashboard Dashboard related features Feature:Filters notabug When the issue is closed this label Indicates that it wasn't a bug

Comments

@snuids
Copy link

snuids commented Sep 7, 2017

**Kibana 5.5.2 **:

**Elastic Search 5.5.2 **:

Kibana Official Docker Image:

In the previous version of kibana, the filter line was not displayed when an embedded dashboard was shared in an iFrame:

Steps to reproduce:
Share any dashboard. And use the link in a new browser window.

screen shot 2017-09-07 at 17 48 05

@debockpierrecofely
Copy link

I've the same issue with this version

@Bargs
Copy link
Contributor

Bargs commented Sep 13, 2017

@lukasolson @stacey-gammon

@lukasolson lukasolson self-assigned this Sep 13, 2017
@stacey-gammon stacey-gammon added the bug Fixes for quality problems that affect the customer experience label Sep 13, 2017
@stacey-gammon
Copy link
Contributor

Thanks for the ping @Bargs. I'm out tomorrow and Friday but will take a look on Monday.

@stacey-gammon stacey-gammon self-assigned this Sep 13, 2017
@lukasolson lukasolson removed their assignment Sep 13, 2017
@stacey-gammon
Copy link
Contributor

This is fixed in 6.0 and onward, but broken in 5.6.

@stacey-gammon
Copy link
Contributor

Given the low severity of this issue, and that it's already fixed in 6.0 and onward, I'm going to go ahead and close.

@stacey-gammon
Copy link
Contributor

On second thought, I will throw in a fix for the next 5.6 release.

@stacey-gammon
Copy link
Contributor

Sorry for the constant stream of contradictory updates, but we've discussed this a bit more in #14076 and decided that because the filter bar will show up if there are some filters, it should always be accessible.

Hence, we won't change this functionality in 5.5, and will fix what is now seen as an issue in 6.0 and onward where the filter bar's appearance is inconsistent.

Long term, we hope to give options to creators of embeddable dashboards where they can say "never show the filter bar", so it will remain hidden even if filters are applied.

cc @elastic/kibana-discovery

@stacey-gammon stacey-gammon added notabug When the issue is closed this label Indicates that it wasn't a bug and removed bug Fixes for quality problems that affect the customer experience labels Sep 20, 2017
@Nikhilsb
Copy link

This issue is still happening in the latest version 6.2.2. Is there any workaround for this ?

@stacey-gammon
Copy link
Contributor

The filter bar is now supposed to always show up in embedded mode because a user can add filters in embedded mode by clicking on visualizations, so this is working as intended.

When #9575 is addresed, it should help by giving the creator of the embedded link more options on how it's presented (e.g. don't allow filters to be added or removed and hide the filter bar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:Filters notabug When the issue is closed this label Indicates that it wasn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants