Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor alerting task runner - remove RecoveryActionGroupId #139208

Open
Tracked by #124206
doakalexi opened this issue Aug 22, 2022 · 1 comment
Open
Tracked by #124206

Refactor alerting task runner - remove RecoveryActionGroupId #139208

doakalexi opened this issue Aug 22, 2022 · 1 comment
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@doakalexi
Copy link
Contributor

doakalexi commented Aug 22, 2022

Meta issue: #124206

While Ersin was working on the alerts summary POC he realized that having a separate RecoveryActionGroupId is making refactoring hard. It is forcing us to do tons of type conversion tricks. Can't we get rid of it? it's just another ActionGroupId, why do we separate it?

@mikecote mikecote added the technical debt Improvement of the software architecture and operational architecture label Sep 1, 2022
@mikecote
Copy link
Contributor

mikecote commented Jan 5, 2023

I found a place using a custom recovery action group. It's within the geo threshold rule type => https://github.com/elastic/kibana/blob/main/x-pack/plugins/stack_alerts/server/rule_types/geo_containment/alert_type.ts#L233-L238 so we'll have to keep that in mind if we remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
No open projects
Development

No branches or pull requests

2 participants