[Security Solution]: Selected few rules doesn't get unselect while user refresh the rule list page.

[ghost]

Describe the bug:
Selected few rules doesn't get unselect while user refresh the rule list page.

Build Details:

VERSION: 8.5.0-SNAPSHOT
BUILD: 55998
COMMIT: 01ecbd48f3657327cb5375b54195cd07bfc4027f

Preconditions

1. Kibana should be running.

Steps to Reproduce

1. Navigate to Alerts tab.
2. Go to Rules tab.
3. Bulk select all available rules.
4. Now, refresh the rule list page.
5. Observe that selected few rules doesn't get unselect while user refresh the rule list page.

Actual Result
Selected few rules doesn't get unselect while user refresh the rule list page.

Expected Result
Selected few rules should get unselect while user refresh the rule list page.

Screen-Recording:

Rules.-.Kibana.-.Google.Chrome.2022-09-07.14-18-20.mp4

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[elasticmachine]

Pinging @elastic/security-detections-response (Team:Detections and Resp)

[banderror]

Expected Result
Selected few rules should get unselect while user refresh the rule list page.

@samratbhadra-qasource I'm not sure about that. From my perspective the expected result, in this case, should be:

"All rules on the page should stay selected after the table is refreshed."

[banderror]

@vitaliidm Do you think it's a regression after fixing #135297 or a separate (unrelated to #135297) bug?

[xcrzx]

Note: it would probably make sense to implement elastic/eui#6184 first to make table row selection logic more straightforward. That could help to prevent more selection bugs in the future

[vitaliidm]

@vitaliidm Do you think it's a regression after fixing #135297 or a separate (unrelated to #135297) bug?

It's not regression, those ticket covered only losing selection after auto-refresh, by pausing it.
Here, user forces refresh by pressing Refresh button.

I would say, we probably should just remove selection from all rules when Refresh button is pressed.
OR
We can disable refresh button, when there is any selected rule, similar to auto-refresh control

[vitaliidm]

Note: it would probably make sense to implement elastic/eui#6184 first to make table row selection logic more straightforward. That could help to prevent more selection bugs in the future

I think, items are losing their selection here due to changed order of rules in Elastic response. More details here

[banderror]

It's not regression, those ticket covered only losing selection after auto-refresh, by pausing it.
Here, user forces refresh by pressing Refresh button.

@vitaliidm Thanks, I re-read the ticket and comments there, and now I get it 👍

Let's discuss the options we have when someone starts working on a fix.

[maximpn]

@samratbhadra-qasource @MadameSheema it looks the bug has been fixed by #135297. I can't reproduce it on the recent main (8.7).

Screen.Recording.2022-11-18.at.15.40.13.mov

[xcrzx]

@samratbhadra-qasource @MadameSheema it looks the bug has been fixed by #135297. I can't reproduce it on the recent main (8.7).

This bug is reproduced only when the order of rules changes on the page. That happens, for example, when a rule runs. The rule sorting order is stable in the video recording above, so the bug is not reproducible.

[ghost]

Hi @maximpn

We have validated this issue on the latest 8.6.0-BC1 build and observed that the issue is fixed. Please find below the testing details:

Build Details:

VERSION: 8.6.0-BC1
BUILD: 58392
COMMIT: 50a7feb0a5eb068d3acccc49c83b9ccb6db6734f

Screen-Recording:

Rules.-.Kibana.-.Google.Chrome.2022-11-22.12-59-55.mp4

Hence, closing this issue and marking it as QA Validated.

cc: @MadameSheema
Thanks!

[xcrzx]

Sorry, I have to reopen this issue. As I commented above:

This bug is reproduced only when the order of rules changes on the page. That happens, for example, when a rule runs. The rule sorting order is stable in the video recording above, so the bug is not reproducible.

See screen recording:

Screen.Recording.2022-11-22.at.10.40.17.mov

[banderror]

@xcrzx Thank you for keeping an eye on this, very much appreciated 🙏

@samratbhadra-qasource Please let us know if you need any help with reproducing this edge case, e.g. concrete steps.

This bug is reproduced only when the order of rules changes on the page. That happens, for example, when a rule runs. The rule sorting order is stable in the video recording above, so the bug is not reproducible.

[banderror]

I moved this bug back to our backlog. Let's revisit it later, maybe we will include it to our 8.7 plan.