Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random sampler aggregation support in Lens #146770

Closed
ruflin opened this issue Dec 1, 2022 · 5 comments
Closed

Random sampler aggregation support in Lens #146770

ruflin opened this issue Dec 1, 2022 · 5 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@ruflin
Copy link
Member

ruflin commented Dec 1, 2022

The random sampler aggregation can help significantly improve query performance for metric aggregations in some scenarios (see for more details: elastic/elasticsearch#91743 ). Unfortunately it is not possible to use it at the moment as there is not support for it in Lens.

As can be seen in elastic/elasticsearch#91743 there are quite a few discussions needed on how exactly the random sampler aggregation would work in Lens, what default it picks and how. Lets use this issue to do that.

It seems as part of the ML feature, random sampler is already supported (#146323, #146160) but we require it to be part of Lens so we can use it in our dashboards.

Related issues

@felixbarny
Copy link
Member

One idea discussed in the linked Elasticsearch issue is to progressively load the charts: We'd start with a very low sampling percentage, render the graph, and do another query if the error from the first query is too high. For the second query, we'll calculate the probability, given the response of the first query, so that the error is kept within a reasonable bound.

@stratoula stratoula added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 1, 2022
@kibanamachine kibanamachine added this to Long-term goals in Lens Dec 1, 2022
@stratoula stratoula added the enhancement New value added to drive a business result label Dec 1, 2022
@ruflin
Copy link
Member Author

ruflin commented Dec 2, 2022

For reference, turns out some work had been already done on this: #143221

@stratoula
Copy link
Contributor

Hey! Yes we had started working on that but we decided to not release it because there were more details that needed to be discussed. @ninoslavmiskovic is on it, gathering all the requirements and talking with stakeholders.

@timductive timductive added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Dec 19, 2022
@dej611
Copy link
Contributor

dej611 commented Apr 13, 2023

This has been finally enabled in Lens with #151749 resolving all raised concerns from the ML team.

@dej611 dej611 closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Long-term goals
Development

No branches or pull requests

6 participants