Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] add function tests for action mustache variables #147219

Open
pmuellr opened this issue Dec 7, 2022 · 1 comment
Open

[ResponseOps] add function tests for action mustache variables #147219

pmuellr opened this issue Dec 7, 2022 · 1 comment
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Dec 7, 2022

While reviewing PR #147136, I realized that we didn't have any function tests for action mustache variables! As near as I could tell. I think we should. For the common variables shared across all rules - so everything except the context.* variables.

Basic idea would be to create any rule, add an index action (or some other action we can capture the output from), get the rule to trigger, then check that the action was executed with the expected variable values.

@pmuellr pmuellr added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework labels Dec 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

2 participants