Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] use geo_hex grid aggregation for heatmap layer #148574

Closed
Tracked by #154870
nreese opened this issue Jan 9, 2023 · 3 comments
Closed
Tracked by #154870

[Maps] use geo_hex grid aggregation for heatmap layer #148574

nreese opened this issue Jan 9, 2023 · 3 comments
Labels
discuss enhancement New value added to drive a business result Feature:Maps impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Jan 9, 2023

Now that geohex_grid aggregation supports geo_shape (added in 8.7), Maps should add support for heatmap layers to use geohex_grid aggregation.

Should aggregation choice be exposed to the user through the UI?

  • Arguments against exposing aggregation in UI:
    • avoid UI complexity and overwhelming users with complex choices they don't understand or care about
  • Arguments for exposing aggregation in UI:
    • geohex_grid aggregation is currently slower then geotile_grid aggregation so heatmap layer my be slower with geohex_grid aggregation.
    • geohex_grid aggregation is a licensed feature for on prem. On prem users without a subscrition would have to fall back to geotile_grid aggregation.
@nreese nreese added discuss enhancement New value added to drive a business result Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps labels Jan 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Jan 23, 2023

Started working on a POC implementation and LOE is higher than anticipated, more likely a few days. Hard part is properly setting heatmap-radius for hexagons. Current implementation for grid tiles uses hard coded values based on resolution. This will not work for hexagons because hexagon radius does not scale 1:1 with zoom level, and hexagon radius increases as latitudes get closer to poles.

Chatted with @iverase about the issue and Ignacio suggested setting heatmap-radius to radius of hexagon. This is possible since heatmap-radius supports expressions and feature-state.

Hexagon feature provided by Elasticsearch vector tile does not contain this radius. Radius would have to be calculated and converted to pixels and added to feature-state to be available in expressions.

@nreese nreese added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jan 26, 2023
@nreese
Copy link
Contributor Author

nreese commented Apr 12, 2023

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Maps ice box #154870

@nreese nreese closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result Feature:Maps impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

2 participants