Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Replace labs:dashboard:deferBelowFold advanced setting with dashboard option #150459

Open
Tracked by #149155
nreese opened this issue Feb 7, 2023 · 5 comments
Labels
blocked Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects

Comments

@nreese
Copy link
Contributor

nreese commented Feb 7, 2023

Blocked by #148933

labs:dashboard:deferBelowFold was added by #99880 in May 2021. This is a great feature that is hidden behind a labs flag and lightly used.

We discussed the following options for promoting the setting out of labs:

  • Remove lab setting and load all dashboards with defer below the fold.
    • rejected because some users may load dashboard, get coffee and return to computer and expect the entire dashboard to have loaded
  • Promote labs:dashboard:deferBelowFold out of labs and keep as advanced setting dashboard:deferBelowFold
    • rejected because feature would remain hidden/seldom used
  • Remove feature entirely
    • rejected because feature has value on limiting workload of elasticsearch cluster and allowing visible part of screen to load faster

labs:dashboard:deferBelowFold flag should be removed and replaced with a dashboard option so that loading can be configured per dashboard by the dashboard author.

@nreese nreese added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Feb 7, 2023
@nreese nreese changed the title Move delayed panel loading from lab setting to dashboard option [Dashboard] Move delayed panel loading from lab setting to dashboard option Feb 7, 2023
@nreese nreese changed the title [Dashboard] Move delayed panel loading from lab setting to dashboard option [Dashboard] Replace labs:dashboard:deferBelowFold advanced setting with dashboard option Feb 7, 2023
@nreese nreese added the blocked label Feb 7, 2023
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 9, 2023
@kibanamachine kibanamachine added this to Inbox in Dashboard Feb 9, 2023
@teresaalvarezsoler
Copy link

@nreese Thanks for the thorough thinking and the transparency on the decisions made.

In order for the visualizations "below fold" to load, do we need to make all the queries again to Elasticsearch (i.e., users will have to wait the entire time to connect to the cluster, etc.) or do we already have the data and it is just a matter of rendering the visualizations, applying formulas, etc.?

@nreese
Copy link
Contributor Author

nreese commented Jun 29, 2023

In order for the visualizations "below fold" to load, do we need to make all the queries again to Elasticsearch (i.e., users will have to wait the entire time to connect to the cluster, etc.) or do we already have the data and it is just a matter of rendering the visualizations, applying formulas, etc.?

Any panel below the page edge is not loaded until users scroll down and the panel is in the visible portion of the page. This means that data is not fetched until the panel is in view. This has the benefit of speeding up loading of visible panels since there are fewer requests sent to elasticsearch.

@teresaalvarezsoler
Copy link

Remove lab setting and load all dashboards with defer below the fold.
rejected because some users may load dashboard, get coffee and return to computer and expect the entire dashboard to have loaded

Can we first load the visible panels and the non-visible ones afterwards (without requiring the user to scroll)? That way all the panels will load even if the user is not making "focus" on them.

@nreese
Copy link
Contributor Author

nreese commented Jun 29, 2023

Can we first load the visible panels and the non-visible ones afterwards (without requiring the user to scroll)? That way all the panels will load even if the user is not making "focus" on them.

I am sure that could be accomplished, but that is not how the feature works today.

@andremacola
Copy link

Related to #176535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
No open projects
Dashboard
  
Inbox
Development

No branches or pull requests

4 participants