Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard][Embed] Snapshot version iframe throws React error when embedded in Safari #151338

Closed
Tracked by #168126
dej611 opened this issue Feb 15, 2023 · 4 comments
Closed
Tracked by #168126

[Dashboard][Embed] Snapshot version iframe throws React error when embedded in Safari #151338

dej611 opened this issue Feb 15, 2023 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
Dashboard

Comments

@dej611
Copy link
Contributor

dej611 commented Feb 15, 2023

Describe the bug:

Embedding a dashboard via the provided iframe code does not work in Safari, throwing a React error about hooks.
It happens for both long and Short URL mode. It does not happen for Saved Object iframe version.

Screenshot 2023-02-15 at 17 18 09
@dej611 dej611 added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Feb 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@dej611 dej611 changed the title [Dashboard][Embed] Snapshot version iframe throws React error when embedded [Dashboard][Embed] Snapshot version iframe throws React error when embedded in Safari Feb 15, 2023
@kibanamachine kibanamachine added this to Inbox in Dashboard Feb 15, 2023
@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Feb 15, 2023
@Heenawter Heenawter added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Feb 15, 2023
@dej611
Copy link
Contributor Author

dej611 commented Feb 15, 2023

Interesting enough, if I use hot reload in the external app and change and restore the snapshot iframe code, then I can see the whole Kibana frame:

Screenshot 2023-02-15 at 17 41 31

Apps will fail to render, BUT I can use search to look into stuff in Kibana (of course it depends on the roles associated with the logged user):

Screenshot 2023-02-15 at 17 41 49

@ThomThomson
Copy link
Contributor

Recategorizing this as impact:medium, because the iframe functionality is not very well supported.

@ThomThomson ThomThomson added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Feb 21, 2023
@ThomThomson
Copy link
Contributor

Closing this for the time being. It will be tracked in our Icebox for Iframe / Embedding issues and will be re-opened if our priorities change.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
@ThomThomson ThomThomson mentioned this issue Apr 10, 2023
Open
@ThomThomson ThomThomson mentioned this issue Oct 5, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
No open projects
Dashboard
  
Inbox
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dej611 @Heenawter @ThomThomson @elasticmachine @kibanamachine