Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Audit test coverage: Rule Management area #153637

Open
Tracked by #153633
banderror opened this issue Mar 24, 2023 · 2 comments
Open
Tracked by #153633

[Security Solution] Audit test coverage: Rule Management area #153637

banderror opened this issue Mar 24, 2023 · 2 comments
Assignees
Labels
Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test_ui_functional test test-api-integration test-coverage issues & PRs for improving code test coverage

Comments

@banderror
Copy link
Contributor

banderror commented Mar 24, 2023

Epic: #153633

Summary

Audit existing test coverage for the Rule Management area.

  • Create a list of all Detection & Response features that are owned by the @elastic/security-detection-rule-management team.
  • Review existing test coverage and see how it matches the list of features.
  • For each feature:
    • evaluate the coverage at each level (E2E, integration, unit; e.g. full, some, none)
    • determine gaps (e.g. this use case is covered, but that one is not; integration tests exist but e2e tests are missing)
    • check if there are any Cypress tests we can drop because the behavior is already covered at a different level (integration or unit)
    • check if there are any Cypress tests that can be covered at a different level (integration or unit)
    • check for any unnecessary/redundant actions or assertions in Cypress tests -- these should be either removed or extracted into other tests

Document and share the results of the audit with the other 2 area teams.

Based on the results, create as many GitHub issues as needed, titled [Security Solution] Increase test coverage for <Feature X>. In general, the goals of each of these issues should be:

  • Write a test plan for <Feature X>.
  • Write missing tests.
  • Fix and improve existing tests: make them less flaky and brittle (reduce false negatives), more isolated from each other, etc.

Feel free to add any other goals specific to the feature.

Add all the newly created issues to #161509.

@banderror banderror added test test_ui_functional test-api-integration test-coverage issues & PRs for improving code test coverage Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team 8.8 candidate labels Mar 24, 2023
@banderror banderror self-assigned this Mar 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror added the technical debt Improvement of the software architecture and operational architecture label Mar 24, 2023
@banderror banderror changed the title [Security Solution] Audit existing test coverage for the Rules area [Security Solution] Audit existing test coverage for the Rule Management area May 22, 2023
@banderror banderror changed the title [Security Solution] Audit existing test coverage for the Rule Management area [Security Solution] Audit test coverage: Rule Management area Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture test_ui_functional test test-api-integration test-coverage issues & PRs for improving code test coverage
Projects
None yet
Development

No branches or pull requests

2 participants