Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Replace statically exported RxJS subjects #153943

Open
1 task
darnautov opened this issue Mar 29, 2023 · 1 comment
Open
1 task

[ML] Replace statically exported RxJS subjects #153943

darnautov opened this issue Mar 29, 2023 · 1 comment
Assignees
@darnautov
Labels
:ml refactoring Team:ML Team label for ML (also use :ml) technical debt Improvement of the software architecture and operational architecture

Comments

@darnautov
Copy link
Contributor

darnautov commented Mar 29, 2023 •
edited

Statically exported RxJS subjects can lead to unexpected updates coming from outside of the app context. Instead, we should introduce services initialised in the app context with dedicated methods for updates and subjects exposed as observables, similar to the ChartTooltipService.
@darnautov darnautov added :ml technical debt Improvement of the software architecture and operational architecture Team:ML Team label for ML (also use :ml) labels Mar 29, 2023
@darnautov darnautov self-assigned this Mar 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darnautov darnautov

Labels
:ml refactoring Team:ML Team label for ML (also use :ml) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darnautov @elasticmachine